enhancement(notification): add white list check for webhook to prevent SSRF #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckyPickleZZ
requested review from
MarkPotato777,
yhilmare and
yizhouxw
as code owners
...vice/src/main/java/com/oceanbase/odc/service/notification/helper/ChannelConfigValidator.java
Outdated
Show resolved
Hide resolved
yizhouxw
approved these changes
Apr 2, 2024
ungreat
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-enhancement
What this PR does / why we need it:
The webhook url was not validated, this may cause SSRF attack.
So we added a system configuration
odc.notification.host-white-list, only allow to create channel with webhook in this list.