feat(collaboration): support for configuring database administrators and participating in approvals #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(database-owner): 1. Add the owner role to the database, supporting approval workflow to use the owner role of the database. 2. Add variables for integrating external approval. such as: database.owner.accounts database.owner.ids database.owner.names database.name environment.name task.description risk.level 2024-02-29 * feat(database-owner): 1. Add the owner role to the database, supporting approval workflow to use the owner role of the database. 2. Add variables for integrating external approval. such as: database.owner.accounts database.owner.ids database.owner.names database.name environment.name task.description risk.level 2024-02-29 * feat(database-owner): 1. Add the owner role to the database, supporting approval workflow to use the owner role of the database. 2. Add variables for integrating external approval. such as: database.owner.accounts database.owner.ids database.owner.names database.name environment.name task.description risk.level 2024-02-29 * feat(database-owner): 1. Add the owner role to the database, supporting approval workflow to use the owner role of the database. 2. Add variables for integrating external approval. such as: database.owner.accounts database.owner.ids database.owner.names database.name environment.name task.description risk.level odc.task.url 3. Adjust the database permission request form, and split the form when applying for multiple databases. 2024-03-06 * feat(database-owner): 1. Add the owner role to the database, supporting approval workflow to use the owner role of the database. 2. Add variables for integrating external approval. such as: database.owner.accounts database.owner.ids database.owner.names database.name environment.name task.description risk.level odc.task.url 3. Adjust the database permission request form, and split the form when applying for multiple databases. 2024-03-06 * feat(database-owner): 1. Add the owner role to the database, supporting approval workflow to use the owner role of the database. 2. Add variables for integrating external approval. such as: database.owner.accounts database.owner.ids database.owner.names database.name environment.name task.description risk.level odc.task.url 3. Adjust the database permission request form, and split the form when applying for multiple databases. 2024-03-07 * feat(database-owner): 1. Add the owner role to the database, supporting approval workflow to use the owner role of the database. 2. Add variables for integrating external approval. such as: database.owner.accounts database.owner.ids database.owner.names database.name environment.name task.description risk.level odc.task.url 3. Adjust the database permission request form, and split the form when applying for multiple databases. 2024-03-08 * feat(database-owner): 1. Add the owner role to the database, supporting approval workflow to use the owner role of the database. 2. Add variables for integrating external approval. such as: database.owner.accounts database.owner.ids database.owner.names database.name environment.name task.description risk.level odc.task.url 3. Adjust the database permission request form, and split the form when applying for multiple databases. 2024-03-08 * feat(database-owner): 1. Add the owner role to the database, supporting approval workflow to use the owner role of the database. 2. Add variables for integrating external approval. such as: database.owner.accounts database.owner.ids database.owner.names database.name environment.name task.description risk.level odc.task.url 3. Adjust the database permission request form, and split the form when applying for multiple databases. 2024-03-08
# Conflicts: # server/odc-service/src/main/java/com/oceanbase/odc/service/connection/database/DatabaseService.java
smallsheeeep
added
type-feature
smallsheeeep
changed the title
smallsheeeep
requested review from
yhilmare,
yizhouxw,
ungreat,
MarkPotato777,
krihy and
LuckyPickleZZ
as code owners
...-server/src/main/java/com/oceanbase/odc/server/web/controller/v2/FlowInstanceController.java
Outdated
Show resolved
Hide resolved
...dc-service/src/main/java/com/oceanbase/odc/service/collaboration/project/ProjectService.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/FlowInstanceService.java
Show resolved
Hide resolved
...er/odc-service/src/main/java/com/oceanbase/odc/service/flow/model/CreateFlowInstanceReq.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/iam/ResourceRoleService.java
Show resolved
Hide resolved
...c-service/src/main/java/com/oceanbase/odc/service/regulation/risklevel/RiskLevelService.java
Outdated
Show resolved
Hide resolved
yhilmare
reviewed
Apr 11, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/FlowInstanceService.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/FlowInstanceService.java
Show resolved
Hide resolved
LuckyPickleZZ
approved these changes
Apr 11, 2024
krihy
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-feature
module-collaboration
What this PR does / why we need it:
In common usage, users wanna that the tickets related to different databases are approved by different user. Which means that the approvers is related to the database.
This PR implements these features:
by:
DatabaseController, add a new APImodifyDatabasesOwnerfor configuring database adminiatrators;V_4_3_0_1__add_resource_role.yaml, addOWNERofODC_DATABASE;SQL_CONTENT_JSON_ARRAY("sql.content.json.array")DATABASE_OWNERS_IDS("database.owner.ids")DATABASE_OWNERS_ACCOUNTS("database.owner.accounts")DATABASE_OWNERS_NAMES("database.owner.names")DATABASE_NAME("database.name")ENVIRONMENT_NAME("environment.name")TASK_DESCRIPTION("task.description")RISK_LEVEL("risk.level")PROJECT_OWNER_IDS("project.owner.ids")PROJECT_OWNER_ACCOUNTS("project.owner.accounts")PROJECT_OWNER_NAMES("project.owner.names")ODC_TASK_URL("odc.task.url")Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: