Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taskframework): calculate capacity of task in single node by node memory #2174

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

krihy
Copy link
Collaborator

@krihy krihy commented Apr 8, 2024

What type of PR is this?

calculate capacity of task size in single node by node memory

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@krihy krihy added the enhancement New feature or request label Apr 8, 2024
@krihy krihy self-assigned this Apr 8, 2024
@krihy krihy changed the title fix(taskframework): add node memory for calculate capacity running task size in single node fix(taskframework): calculate capacity of task size in single node by node memory Apr 8, 2024
@krihy krihy requested a review from guowl3 April 8, 2024 12:23
@krihy krihy marked this pull request as ready for review April 8, 2024 12:23
guowl3
guowl3 previously approved these changes Apr 8, 2024
Copy link
Collaborator

@guowl3 guowl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the best solution is to obtain the specifications of the expansion node through the API.
ok, i will discuss with other team

@krihy krihy changed the title fix(taskframework): calculate capacity of task size in single node by node memory fix(taskframework): calculate capacity of task in single node by node memory Apr 8, 2024
@yizhouxw yizhouxw merged commit 96d349e into dev/4.2.x Apr 9, 2024
11 checks passed
@yizhouxw yizhouxw deleted the yaobin_taskframework_add_node_memory branch April 9, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants