Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pl-debug): make timeout settings can be overwritten by session init script #2179

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

yhilmare
Copy link
Contributor

@yhilmare yhilmare commented Apr 9, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

the pldebug's session timeout settings is hard code and can not be modified.
I run these timeout settings after session init script to avoid this issue~

Which issue(s) this PR fixes:

Fixes #2172

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@yhilmare yhilmare added the type-bug Something isn't working label Apr 9, 2024
@yhilmare yhilmare added this to the ODC 4.2.4 milestone Apr 9, 2024
@yhilmare yhilmare self-assigned this Apr 9, 2024
@yhilmare yhilmare requested a review from krihy as a code owner April 9, 2024 03:12
@yhilmare yhilmare requested a review from yizhouxw April 9, 2024 03:13
Copy link
Collaborator

@krihy krihy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 4c6f8c6 into dev/4.2.x Apr 9, 2024
11 checks passed
@yhilmare yhilmare deleted the fix/shanlu_pl_debug branch April 9, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: failed to debug a pl that contains a sql costing more than 10 minutes
3 participants