Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-transfer): obloader fail to load MANIFEST.bin #2181

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

LuckyPickleZZ
Copy link
Collaborator

What type of PR is this?

type-bug

What this PR does / why we need it:

In the earlier version, ob-loader-dumper would save binary files like MANIFEST.bin in data directory.
But in obloader-2.4.8.2, it has changed the file path into root directory. So ODC has adapted this feature.

FROM

root
└── data
    ├── TABLE
    │      └── xxx.sql
    └── MANIFEST.bin

TO

root
├── data
│     └── TABLE
│          └── xxx.sql
└── MANIFEST.bin

Which issue(s) this PR fixes:

Fixes #2176

@LuckyPickleZZ LuckyPickleZZ added this to the ODC 4.2.4-bp milestone Apr 9, 2024
@LuckyPickleZZ LuckyPickleZZ self-assigned this Apr 9, 2024
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could the object provided by earlier ob-loader-dumper be imported?

@LuckyPickleZZ
Copy link
Collaborator Author

could the object provided by earlier ob-loader-dumper be imported?

yes, ODC finds MANIFEST.bin by scanning directories. As long as ODC can find the manifest file, it can be output to the working directory of ob-loader

@yhilmare yhilmare merged commit 5505157 into dev/4.2.x Apr 9, 2024
11 checks passed
@yhilmare yhilmare deleted the wenmu_424_fix_fail_get_manifest branch April 9, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants