fix(db-browser): adaption for ALL_TAB_COLS.USER_GENERATED in ob oracle #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeachThinking
added
type-bug
PeachThinking
requested review from
LuckyPickleZZ,
yhilmare and
MarkPotato777
as code owners
|
please upgrade db-browser's version~ |
Done～ |
...db-browser/src/main/java/com/oceanbase/tools/dbbrowser/schema/DBSchemaAccessorGenerator.java
Outdated
Show resolved
Hide resolved
libs/db-browser/src/main/resources/schema/sql/oboracle/oboracle_4_1_x.yaml
Show resolved
Hide resolved
|
there are several conflicts between your branch and dev/4.3.0 |
yhilmare
reviewed
May 23, 2024
...er/src/main/java/com/oceanbase/tools/dbbrowser/editor/generator/DBObjectEditorGenerator.java
Outdated
Show resolved
Hide resolved
...main/java/com/oceanbase/tools/dbbrowser/schema/oracle/OBOracleLessThan400SchemaAccessor.java
Show resolved
Hide resolved
libs/db-browser/src/main/resources/schema/sql/oboracle/oboracle_4_1_x.yaml
Show resolved
Hide resolved
libs/db-browser/src/main/resources/schema/sql/oboracle/oboracle_4_1_x.yaml
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/db/browser/DBSchemaAccessors.java
Outdated
Show resolved
Hide resolved
...va/com/oceanbase/odc/plugin/schema/odpsharding/obmysql/ODPShardingOBMySQLTableExtension.java
Outdated
Show resolved
Hide resolved
yhilmare
approved these changes
May 27, 2024
yhilmare
approved these changes
May 27, 2024
yizhouxw
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
ob 4.1.0 and above version
ALL_TAB_COLSadds theUSER_GENERATEDfield. If it is a deleted column, thenUSER_GENERATED = 'YES'， these columns do not need to be displayed on a white screen on ODC to the user. The newoboracle_4_1_x.yamlis added to filter theUSER_GENERATEDfield. At the same time,OBOracleBetween4000And4100SchemaAccessoris added.put the creation of
DBSchemaAccessorin db-browser layer ：DBSchemaAccessorGeneratorput the creation of
DBStatsAccessorin db-browser layer ：DBStatsAccessorGeneratorput the creation of
DBObjectEditorin db-browser layer ：DBObjectEditorGeneratorput the creation of
DBObjectTemplatein db-browser layer ：DBObjectTemplateGeneratorWhich issue(s) this PR fixes:
Fixes #2208
Fixes #1771
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: