refactor(sql-execute): refactor SQL async execute api into streaming return #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckyPickleZZ
added
type-feature
yhilmare
reviewed
Apr 18, 2024
server/odc-core/src/main/java/com/oceanbase/odc/core/session/ConnectionSessionUtil.java
Show resolved
Hide resolved
server/odc-core/src/main/java/com/oceanbase/odc/core/session/ConnectionSessionUtil.java
Show resolved
Hide resolved
server/odc-core/src/main/java/com/oceanbase/odc/core/session/ConnectionSessionUtil.java
Outdated
Show resolved
Hide resolved
.../odc-service/src/main/java/com/oceanbase/odc/service/connection/util/ConnectionInfoUtil.java
Outdated
Show resolved
Hide resolved
.../odc-service/src/main/java/com/oceanbase/odc/service/connection/util/ConnectionInfoUtil.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/ConnectConsoleService.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/ConnectConsoleService.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/ConnectConsoleService.java
Outdated
Show resolved
Hide resolved
...r/odc-service/src/main/java/com/oceanbase/odc/service/session/model/AsyncExecuteContext.java
Outdated
Show resolved
Hide resolved
|
pr gets conflict with dev/4.3.x |
yhilmare
reviewed
Apr 23, 2024
server/odc-core/src/main/java/com/oceanbase/odc/core/session/ConnectionSessionUtil.java
Show resolved
Hide resolved
.../odc-service/src/main/java/com/oceanbase/odc/service/connection/util/ConnectionInfoUtil.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/ConnectConsoleService.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/ConnectConsoleService.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/ConnectConsoleService.java
Outdated
Show resolved
Hide resolved
...r/odc-service/src/main/java/com/oceanbase/odc/service/session/model/AsyncExecuteContext.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/OdcStatementCallBack.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/OdcStatementCallBack.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/OdcStatementCallBack.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/OdcStatementCallBack.java
Show resolved
Hide resolved
…mu_430_feat_refactor_async_execute
…mu_430_feat_refactor_async_execute # Conflicts: # server/odc-service/src/main/java/com/oceanbase/odc/service/session/OdcStatementCallBack.java
yhilmare
reviewed
Apr 24, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/session/ConnectConsoleService.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/ConnectConsoleService.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/OdcStatementCallBack.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/SqlExecutionListener.java
Outdated
Show resolved
Hide resolved
...r/odc-service/src/main/java/com/oceanbase/odc/service/session/model/AsyncExecuteContext.java
Outdated
Show resolved
Hide resolved
...r/odc-service/src/main/java/com/oceanbase/odc/service/session/model/AsyncExecuteContext.java
Outdated
Show resolved
Hide resolved
...r/odc-service/src/main/java/com/oceanbase/odc/service/session/model/AsyncExecuteContext.java
Outdated
Show resolved
Hide resolved
...r/odc-service/src/main/java/com/oceanbase/odc/service/session/model/AsyncExecuteContext.java
Outdated
Show resolved
Hide resolved
...r/odc-service/src/main/java/com/oceanbase/odc/service/session/model/AsyncExecuteContext.java
Outdated
Show resolved
Hide resolved
...r/odc-service/src/main/java/com/oceanbase/odc/service/session/model/AsyncExecuteContext.java
Show resolved
Hide resolved
yhilmare
reviewed
Apr 24, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/session/OdcStatementCallBack.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/ConnectConsoleService.java
Outdated
Show resolved
Hide resolved
smallsheeeep
previously approved these changes
Apr 24, 2024
server/odc-core/src/main/java/com/oceanbase/odc/core/session/ConnectionSessionUtil.java
Show resolved
Hide resolved
yizhouxw
reviewed
Apr 25, 2024
...erver/src/main/java/com/oceanbase/odc/server/web/controller/v2/ConnectSessionController.java
Outdated
Show resolved
Hide resolved
...erver/src/main/java/com/oceanbase/odc/server/web/controller/v2/ConnectSessionController.java
Outdated
Show resolved
Hide resolved
.../odc-service/src/main/java/com/oceanbase/odc/service/connection/util/ConnectionInfoUtil.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/ConnectConsoleService.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/session/ConnectConsoleService.java
Outdated
Show resolved
Hide resolved
LuckyPickleZZ
dismissed stale reviews from smallsheeeep, ungreat, and yhilmare
via
1ab297d
ungreat
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-feature
What this PR does / why we need it:
In ODC 4.3.0, We hope to refactor the SQL async execute api into a streaming return method. Each time, it returns the results that has already been finished.
Therefore, I added a
AsyncExecuteContextto cache the results ofODCStatementCallBack.When the ODC server receives a request for
getResult, it will first block for one second to determine whether the SQL execution is complete.If the execution is completed, the result will be directly returned. The status is SUCCESS.
If it is not completed, the results completed during the period from the last request to now will be returned. At this point, the status is RUNNING.