Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(databasechange): implement the new interface and flow of multiple databases change #2275

Merged
merged 58 commits into from
May 20, 2024

Conversation

zijiacj
Copy link
Collaborator

@zijiacj zijiacj commented Apr 23, 2024

What type of PR is this?

type-feature

What this PR does / why we need it:

Implement the new interface of multiple databases change

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@zijiacj zijiacj self-assigned this Apr 23, 2024
@zijiacj zijiacj marked this pull request as draft April 23, 2024 02:01
@zijiacj zijiacj changed the title Feat/zijia multi database implement [WIP]Feat/zijia multi database implement Apr 23, 2024
@zijiacj zijiacj added this to the ODC 4.3.0 milestone Apr 23, 2024
@zijiacj zijiacj added the type-feature The functionality to be implemented label Apr 23, 2024
@zijiacj zijiacj changed the title [WIP]Feat/zijia multi database implement [WIP]Feat(databasechange)/Implement the new interface of multiple databases change Apr 23, 2024
@yhilmare yhilmare changed the title [WIP]Feat(databasechange)/Implement the new interface of multiple databases change [WIP] feat(databasechange): implement the new interface of multiple databases change Apr 23, 2024
@zijiacj zijiacj changed the base branch from dev/4.3.x to dev/4.3.0 May 20, 2024 02:26
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

congratuations!

Copy link
Collaborator

@LuckyPickleZZ LuckyPickleZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@PeachThinking PeachThinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 48a1cf2 into dev/4.3.0 May 20, 2024
9 checks passed
@yhilmare yhilmare deleted the feat/zijia_multi_database_implement branch May 20, 2024 11:52
@zijiacj zijiacj restored the feat/zijia_multi_database_implement branch May 21, 2024 04:27
@zijiacj zijiacj deleted the feat/zijia_multi_database_implement branch May 21, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature The functionality to be implemented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants