Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema-plugin): remove the logic that automatically converts table names to lowercase when getTable #2298

Conversation

PeachThinking
Copy link
Collaborator

… when getTable

What type of PR is this?

What this PR does / why we need it:

remove the logic that automatically converts table names to lowercase when getTable

Which issue(s) this PR fixes:

Fixes #2239

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@PeachThinking PeachThinking added the type-bug Something isn't working label Apr 25, 2024
@PeachThinking PeachThinking added this to the ODC 4.3.0 milestone Apr 25, 2024
@PeachThinking PeachThinking self-assigned this Apr 25, 2024
…able_with_uppercase_names_under_tenant_lower_case_table_names=2
MarkPotato777
MarkPotato777 previously approved these changes May 17, 2024
Copy link
Collaborator

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeachThinking PeachThinking changed the base branch from dev/4.3.x to dev/4.3.0 May 17, 2024 09:06
@PeachThinking PeachThinking dismissed MarkPotato777’s stale review May 17, 2024 09:06

The base branch was changed.

Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit b15f00b into dev/4.3.0 May 20, 2024
7 checks passed
@yhilmare yhilmare deleted the fix/jingtian_430_fix_Unable_to_open_a_table_with_uppercase_names_under_tenant_lower_case_table_names=2 branch May 20, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants