fix(flow): optimize flow submitter about exception handler #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krihy
added
type-bug
yhilmare
changed the title
|
👏 great job |
krihy
changed the title
yizhouxw
reviewed
May 20, 2024
...c-service/src/main/java/com/oceanbase/odc/service/flow/task/FlowTaskResultContextHolder.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/task/FlowTaskSubmitter.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/task/FlowTaskSubmitter.java
Outdated
Show resolved
Hide resolved
yhilmare
reviewed
May 21, 2024
...c-service/src/main/java/com/oceanbase/odc/service/flow/task/FlowTaskResultContextHolder.java
Outdated
Show resolved
Hide resolved
...r/odc-service/src/main/java/com/oceanbase/odc/service/flow/task/BaseODCFlowTaskDelegate.java
Show resolved
Hide resolved
...rvice/src/main/java/com/oceanbase/odc/service/flow/task/FlowTaskCallBackApprovalService.java
Show resolved
Hide resolved
...rvice/src/main/java/com/oceanbase/odc/service/flow/task/FlowTaskCallBackApprovalService.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/task/FlowTaskSubmitter.java
Show resolved
Hide resolved
yhilmare
reviewed
May 21, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/task/ExecutionEntityFacade.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/task/FlowTaskCallBack.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/oceanbase/odc/service/flow/task/FlowTaskCallBackApprovalService.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/oceanbase/odc/service/flow/task/FlowTaskCallBackApprovalService.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/task/FlowTaskSubmitter.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/task/FlowTaskSubmitter.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
optimize
FlowTaskSubmitterabout exception handler, ifBaseRuntimeFlowableDelegatethrow exception, we check theErrorEventDefinitionboundary with the node, if the boundary error code match with current exception, flowTaskCallBackApprovalService will approve the callback task with FAILED, otherwise approve with COMPLETED,by this pr flowTaskCallBackApprovalService do not care about the task type. and flowNode status update by
ExecutionListenerboundary by theErrorEventDefinitionWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
this pr has test passed:
case1: when submit async task and cancel it , the flow status will be
CANCELEDcase2: when submit a invalid sql async task, the flow status will be
FAILEDcase3: when submit a normal sql async task, the flow status will be
COMPLETEDAdditional documentation e.g., usage docs, etc.: