Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deserialization): failed to deserialize the page object #2434

Merged
merged 1 commit into from
May 20, 2024

Conversation

ungreat
Copy link
Collaborator

@ungreat ungreat commented May 20, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@ungreat ungreat self-assigned this May 20, 2024
@ungreat ungreat changed the base branch from dev/4.2.x to dev/4.3.x May 20, 2024 11:23
@ungreat ungreat force-pushed the yiang_fix_page_data_deserialization branch from 99fab96 to be197ae Compare May 20, 2024 11:32
@yhilmare yhilmare changed the title fix(deserialization):add NoArgsConstructor fix(deserialization): failed to deserialize the page object May 20, 2024
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 0a206bf into dev/4.3.x May 20, 2024
7 checks passed
@yhilmare yhilmare deleted the yiang_fix_page_data_deserialization branch May 20, 2024 11:49
@yizhouxw yizhouxw added this to the ODC 4.3.1 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

3 participants