Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(project): optimize error message when update a project name to an existed project name #2464

Merged
merged 1 commit into from
May 23, 2024

Conversation

MarkPotato777
Copy link
Collaborator

What type of PR is this?

type-bug

What this PR does / why we need it:

when update project's name to an existed project name, then exception will be thrown.
This PR optimize the error message.

Which issue(s) this PR fixes:

Fixes #2438

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@MarkPotato777 MarkPotato777 added the type-bug Something isn't working label May 22, 2024
@MarkPotato777 MarkPotato777 added this to the ODC 4.3.0 milestone May 22, 2024
@MarkPotato777 MarkPotato777 self-assigned this May 22, 2024
@MarkPotato777 MarkPotato777 marked this pull request as ready for review May 22, 2024 07:02
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@smallsheeeep smallsheeeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhilmare yhilmare merged commit 233551f into dev/4.3.0 May 23, 2024
7 checks passed
@yhilmare yhilmare deleted the lebie_430_fix_update_project_0522 branch May 23, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants