fix(metadb): change systemConfigDao to systemConfigRepository. #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ungreat
requested review from
smallsheeeep,
yhilmare,
yizhouxw,
MarkPotato777,
LuckyPickleZZ,
PeachThinking,
krihy and
guowl3
as code owners
ungreat
force-pushed
the
yiang_change_system_config_dao_to_repository
branch
from
3c2f5c7
to
d997087
Compare
yizhouxw
reviewed
May 22, 2024
server/odc-service/src/main/java/com/oceanbase/odc/metadb/config/ConfigEntity.java
Show resolved
Hide resolved
ungreat
added a commit
that referenced
this pull request
Jun 4, 2024
* change configSystemRepository * formatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
The field ConfigEntity.key is a reserved word in MySQL, so the workaround employed is using @column("`key`") to avoid conflicts. However, due to differences in how H2 and MySQL handle reserved keywords, the original method is still implemented using jdbcTemplate to maintain compatibility with integration tests.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: