Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multiple databases):database changing order in template cannot be edited #2511

Merged

Conversation

zijiacj
Copy link
Collaborator

@zijiacj zijiacj commented May 27, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

Currently, only the name of the template can be modified. Therefore, the function of modifying the database changing order is added.
Also fixed the bug that the execution record was not displayed after the first batch of execution of the multiple databases ticket

Which issue(s) this PR fixes:

Fixes #2508 #2516

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@zijiacj zijiacj marked this pull request as draft May 27, 2024 08:38
@zijiacj zijiacj self-assigned this May 27, 2024
@zijiacj zijiacj changed the title fix(multiple databases):database changing order cannot be edited fix(multiple databases):database changing order in template cannot be edited May 27, 2024
@zijiacj zijiacj marked this pull request as ready for review May 27, 2024 13:17
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 163ad7c into dev/4.3.0 May 28, 2024
7 checks passed
@yhilmare yhilmare deleted the fix/multiple_database_change_template_cannot_be_edited branch May 28, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants