refactor(flow): add skip auth to flow mapper #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yizhouxw
reviewed
May 29, 2024
It‘s true that most method to skip auth is by passing parameters at present, may need a technical refactor issue to deal with it uniformly. |
yhilmare
changed the title
yizhouxw
previously approved these changes
May 29, 2024
ungreat
requested review from
Jane201510,
JessieWuJiexi,
smallsheeeep,
MarkPotato777,
LuckyPickleZZ and
PeachThinking
as code owners
ungreat
force-pushed
the
yiang_add_skop_to_flow_mapper
branch
from
6603123
to
6ce60be
Compare
yizhouxw
approved these changes
Jun 4, 2024
yhilmare
approved these changes
Jun 4, 2024
...r/odc-service/src/main/java/com/oceanbase/odc/service/flow/model/FlowInstanceDetailResp.java
Show resolved
Hide resolved
yhilmare
removed request for
Jane201510,
LuckyPickleZZ,
MarkPotato777,
smallsheeeep,
JessieWuJiexi and
PeachThinking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: