fix(pldebug): fix debugger create new connection attach debuggee sessionId failed #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krihy
added
type-bug
krihy
requested review from
yhilmare,
tonghan-gsh,
yizhouxw,
smallsheeeep and
PeachThinking
krihy
changed the title
krihy
added
module-PL debugger
and removed
module-Online schema change
yhilmare
pushed a commit
that referenced
this pull request
Jan 15, 2024
…ionId failed (#254) * fix debugger deach dession failed * add comment * format code * remove static from clone ds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
module-pl debugger
What this PR does / why we need it:
bugger attach session failed when connect to proxy
Which issue(s) this PR fixes:
Debugger must connect to database server the same as debuggee, so fix debuggee connect to ob directly, debugger clone a datasource by debuggee datasource and get connection from it.
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: