fix(ticket): failed to approve ticket when input over-sized comment #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhilmare
reviewed
May 29, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/FlowInstanceService.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
module-ticket
What this PR does / why we need it:
When I approve a ticket and input a comment with more than 1024 chars, then exception will be thrown. And the approval status will be failed but the task still executed.
This PR fixd it!
Which issue(s) this PR fixes:
Fixes #2554
Special notes for your reviewer:
Self-test passed.
Additional documentation e.g., usage docs, etc.: