Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multiple database): no execution record is generated before or during a multi-database change task #2569

Merged
merged 7 commits into from
May 31, 2024
Merged

fix(multiple database): no execution record is generated before or during a multi-database change task #2569

merged 7 commits into from
May 31, 2024

Conversation

zijiacj
Copy link
Collaborator

@zijiacj zijiacj commented May 29, 2024

…played in real time

What type of PR is this?

type-bug

What this PR does / why we need it:

  1. Previously, the multi-database change ticket would have execution records only after finishing the first batch. Now it's changed to that there are records of execution displaying once the multi-database change ticket is created.
  2. Added the execution progress display.

Which issue(s) this PR fixes:

Fixes #2516

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:

@zijiacj zijiacj self-assigned this May 29, 2024
yizhouxw
yizhouxw previously approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zijiacj zijiacj requested a review from yizhouxw May 30, 2024 11:01
yhilmare
yhilmare approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit f14dd99 into dev/4.3.0 May 31, 2024
7 checks passed
@yhilmare yhilmare deleted the fix/zijia_multiple_databases_execution_record branch May 31, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhilmare yhilmare yhilmare approved these changes

@krihy krihy Awaiting requested review from krihy krihy is a code owner

@yizhouxw yizhouxw Awaiting requested review from yizhouxw yizhouxw is a code owner

Assignees

@zijiacj zijiacj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zijiacj @yhilmare @yizhouxw