Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-transfer): exception occurs when object exists and configured continue when error #2587

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

LuckyPickleZZ
Copy link
Collaborator

What type of PR is this?

type-bug

What this PR does / why we need it:

When a imported object exists , obloader would report error even if user configured continue when error. So we should eat this exception in this case. To fix #2583 .

And obdumper could only dump table and index with column group configuration by show create table. It's configured by the compactSchema option. To fix #2555

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@LuckyPickleZZ LuckyPickleZZ added this to the ODC 4.3.0 milestone May 31, 2024
@LuckyPickleZZ LuckyPickleZZ self-assigned this May 31, 2024
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 2c7f26b into dev/4.3.0 Jun 3, 2024
7 checks passed
@yhilmare yhilmare deleted the wenmu_430_fix_data_transfer_failed branch June 3, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants