Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flow): the disabled user can still approving or rejecting a flow #2589

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

smallsheeeep
Copy link
Contributor

What type of PR is this?

type-bug
module-flow

What this PR does / why we need it:

For a disabled user, there are some issues:

  1. The user can still be selected as the database owner;
  2. In ticket list, the user still displaied as the flow approval candidates;
  3. The user can still approve the flow.
    This PR fixed it.

Which issue(s) this PR fixes:

Fixes #2550 #2548

Special notes for your reviewer:

Self-test passed.

Additional documentation e.g., usage docs, etc.:


Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@krihy krihy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@yhilmare yhilmare merged commit 2ab9636 into dev/4.3.0 Jun 3, 2024
7 checks passed
@yhilmare yhilmare deleted the bugfix/gaoda_430_fix_disabled_user_operation branch June 3, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Archived in project
4 participants