fix(multiple database): pre sql check node failed #2592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zijiacj
requested review from
smallsheeeep,
yhilmare,
yizhouxw,
MarkPotato777,
LuckyPickleZZ,
PeachThinking,
krihy,
guowl3 and
ungreat
as code owners
yhilmare
changed the title
yhilmare
reviewed
Jun 3, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/FlowInstanceService.java
Outdated
Show resolved
Hide resolved
yhilmare
removed request for
LuckyPickleZZ,
MarkPotato777,
ungreat,
guowl3,
smallsheeeep and
PeachThinking
yhilmare
reviewed
Jun 4, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/FlowInstanceService.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/FlowInstanceService.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/connection/ConnectionService.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/connection/ConnectionService.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/util/FlowTaskUtil.java
Show resolved
Hide resolved
...c-service/src/main/java/com/oceanbase/odc/service/flow/task/PreCheckRuntimeFlowableTask.java
Outdated
Show resolved
Hide resolved
yizhouxw
reviewed
Jun 4, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/util/FlowTaskUtil.java
Outdated
Show resolved
Hide resolved
yizhouxw
previously approved these changes
Jun 5, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/flow/util/FlowTaskUtil.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
The reason for the error is that the value of the password attribute in the data source connection is null. This pr gets the data source connection with the password value for each database
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: