enhancement(db-browser): add factory for several db-browser's factory #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o_db_browser_shanlu
yhilmare
requested review from
smallsheeeep,
yizhouxw,
PeachThinking,
MarkPotato777 and
guowl3
as code owners
smallsheeeep
previously approved these changes
Jun 3, 2024
libs/db-browser/src/test/java/com/oceanbase/tools/dbbrowser/util/DBSchemaAccessors.java
Show resolved
Hide resolved
yizhouxw
reviewed
Jun 3, 2024
libs/db-browser/src/main/java/com/oceanbase/tools/dbbrowser/schema/DBSchemaAccessorFactory.java
Show resolved
Hide resolved
yizhouxw
previously approved these changes
Jun 4, 2024
yizhouxw
approved these changes
Jun 4, 2024
PeachThinking
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-enhancement
What this PR does / why we need it:
add factory for db-browser to init these objects
Which issue(s) this PR fixes:
Fixes #1771
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: