fix(flow-task): optimize error message of flow task cancelation #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckyPickleZZ
requested review from
Jane201510,
JessieWuJiexi,
yizhouxw,
yhilmare and
krihy
as code owners
JessieWuJiexi
approved these changes
Jun 4, 2024
LuckyPickleZZ
restored the
wenmu_430_fix_optimize_cancelled_error_message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
When cancel a database change task, if this task is not started yet, there may be an error 'RollBack task can not be cancelled'. This error message is confusing, we should optimize it.
Which issue(s) this PR fixes:
Fixes #2418
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: