Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flow): cannot find approvers for multiple database change task when using database owner #2625

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

smallsheeeep
Copy link
Contributor

What type of PR is this?

type-bug
module-flow

What this PR does / why we need it:

For multiple database change task, if the flow config is using db owners for approving, then can not find any approvers.
This PR fix it. And the approvers will be any one of all the database owners.

Which issue(s) this PR fixes:

Fixes #2609

Special notes for your reviewer:

Self-test passed.

Additional documentation e.g., usage docs, etc.:


@smallsheeeep smallsheeeep added the type-bug Something isn't working label Jun 3, 2024
@smallsheeeep smallsheeeep added this to the ODC 4.3.0 milestone Jun 3, 2024
@smallsheeeep smallsheeeep self-assigned this Jun 3, 2024
Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 43532a4 into dev/4.3.0 Jun 4, 2024
7 checks passed
@yhilmare yhilmare deleted the bugfix/gaoda_430_fix_multi_async_approval branch June 4, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: The multi-database change approval node does not match any database administrator that can be approved
3 participants