Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multiple database): the method isIntercepted in multiple database pre check node is error #2677

Conversation

zijiacj
Copy link
Collaborator

@zijiacj zijiacj commented Jun 6, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

The previous isIntercepted method logic was incorrect. In the pre-check node, the judgment on the violation level of the multiple database result is skipped

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@zijiacj zijiacj added the type-bug Something isn't working label Jun 6, 2024
@zijiacj zijiacj added this to the ODC 4.3.0 milestone Jun 6, 2024
@zijiacj zijiacj self-assigned this Jun 6, 2024
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 656b30c into dev/4.3.0 Jun 6, 2024
7 checks passed
@yhilmare yhilmare deleted the fix/zijia_error_method_isIntercepted_in_multiple_database_pre_check_node branch June 6, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants