Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dlm): table structure synchronization failed #2682

Merged
merged 12 commits into from
Jun 6, 2024

Conversation

guowl3
Copy link
Collaborator

@guowl3 guowl3 commented Jun 6, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

  1. When a task is canceled, all table statuses are no longer updated to 'Canceled'.
  2. When table structure synchronization fails, the task will no longer be executed.

Which issue(s) this PR fixes:

Fixes #2668

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@guowl3 guowl3 added the type-bug Something isn't working label Jun 6, 2024
@guowl3 guowl3 added this to the ODC 4.3.0 milestone Jun 6, 2024
@guowl3 guowl3 self-assigned this Jun 6, 2024
yizhouxw
yizhouxw previously approved these changes Jun 6, 2024
Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@smallsheeeep smallsheeeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 9eabf4b into dev/4.3.0 Jun 6, 2024
7 checks passed
@yhilmare yhilmare deleted the tianke_430_fix_dlm_4 branch June 6, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Status: Developed
Development

Successfully merging this pull request may close these issues.

4 participants