Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(migrates): add some abstract methods for migrates #275

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

yhilmare
Copy link
Contributor

@yhilmare yhilmare commented Sep 8, 2023

What type of PR is this?

type-refactor

What this PR does / why we need it:

as the increment of the team organization and individual organization, the time cost of resource migration is more and more unacceptable, so that we should migrate all resources when user login or organization created.

We refactor the migrates framework to archive the goal mentioned, so that we can reuse the ability of migrate framework when migrate organization or user's data.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@yhilmare yhilmare added the type-refactor refactor code or rename variables label Sep 8, 2023
@yhilmare yhilmare added this to the ODC 4.2.1 milestone Sep 8, 2023
@yhilmare yhilmare self-assigned this Sep 8, 2023
@yhilmare yhilmare changed the title Refactor/shanlu migrates 1 refactor(migrates): add some abstract methods for migrates Sep 8, 2023
@yhilmare yhilmare changed the base branch from main to dev/4.2.1 September 8, 2023 04:31
MarkPotato777
MarkPotato777 previously approved these changes Sep 8, 2023
Copy link
Collaborator

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhilmare yhilmare merged commit 71cf36b into dev/4.2.1 Sep 8, 2023
11 checks passed
@yhilmare yhilmare deleted the refactor/shanlu_migrates_1 branch September 8, 2023 08:11
yhilmare added a commit that referenced this pull request Jan 15, 2024
* refactor(migrates): add some abstract methods for migrates

* refactor(migrates): add some abstract methods for migrates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-refactor refactor code or rename variables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants