Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audit): client ip length more langer then audit column client_ip_address #2863

Conversation

CHLK
Copy link
Collaborator

@CHLK CHLK commented Jul 2, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

client ip length more langer then audit column client_ip_address

Which issue(s) this PR fixes:

Fixes #1179

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@CLAassistant
Copy link

CLAassistant commented Jul 2, 2024

CLA assistant check
All committers have signed the CLA.

@yhilmare yhilmare added the type-bug Something isn't working label Jul 2, 2024
@yhilmare yhilmare added this to the ODC 4.3.1 milestone Jul 2, 2024
…d move it from WebRequestUtilsTest to AuditUtils
.gitignore Outdated Show resolved Hide resolved
@CHLK CHLK changed the title fix(aduit): client ip length more langer then audit column client_ip_address fix(audit): client ip length more langer then audit column client_ip_address Jul 2, 2024
Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations for first Pull Request!

Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 7f806c9 into dev/4.3.x Jul 3, 2024
7 checks passed
@yhilmare yhilmare deleted the fix/keyang_43x_client_ip_length_more_larger_then_audit_column branch July 3, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants