-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(audit): client ip length more langer then audit column client_ip_address #2863
Merged
yhilmare
merged 5 commits into
dev/4.3.x
from
fix/keyang_43x_client_ip_length_more_larger_then_audit_column
Jul 3, 2024
Merged
fix(audit): client ip length more langer then audit column client_ip_address #2863
yhilmare
merged 5 commits into
dev/4.3.x
from
fix/keyang_43x_client_ip_length_more_larger_then_audit_column
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhilmare
reviewed
Jul 2, 2024
server/odc-service/src/test/java/com/oceanbase/odc/service/common/WebRequestUtilsTest.java
Outdated
Show resolved
Hide resolved
yhilmare
reviewed
Jul 2, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/common/util/WebRequestUtils.java
Outdated
Show resolved
Hide resolved
…d move it from WebRequestUtilsTest to AuditUtils
yhilmare
reviewed
Jul 2, 2024
CHLK
changed the title
fix(aduit): client ip length more langer then audit column client_ip_address
fix(audit): client ip length more langer then audit column client_ip_address
Jul 2, 2024
yizhouxw
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations for first Pull Request!
yhilmare
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
yhilmare
deleted the
fix/keyang_43x_client_ip_length_more_larger_then_audit_column
branch
July 3, 2024 02:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
client ip length more langer then audit column client_ip_address
Which issue(s) this PR fixes:
Fixes #1179
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: