Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pldebug): fix debug obtain connection info from direct connection config #287

Conversation

krihy
Copy link
Collaborator

@krihy krihy commented Sep 8, 2023

What type of PR is this?

type-bug
module-pldebug

What this PR does / why we need it:

fix debug obtain connection info from direct connection config

Which issue(s) this PR fixes:

acquire host and port info should from connection config when config without cluster

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@krihy krihy added this to the ODC 4.2.1 milestone Sep 8, 2023
@krihy krihy self-assigned this Sep 8, 2023
@krihy krihy linked an issue Sep 8, 2023 that may be closed by this pull request
Copy link
Contributor

@smallsheeeep smallsheeeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krihy krihy merged commit 17825e4 into oceanbase:dev/4.2.1 Sep 8, 2023
5 checks passed
@krihy krihy deleted the yaobin_fix_debug_obtain_connection_direct_config branch September 8, 2023 11:38
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
… config (#287)

* fix connectig contain cluster

* ft code

* fix invalid code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: When connection config is direct to ob
2 participants