Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(login): set max_login_record_time_minutes default value to 0 in web mode #3003

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

ungreat
Copy link
Collaborator

@ungreat ungreat commented Jul 24, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # #2939

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@ungreat ungreat self-assigned this Jul 24, 2024
@ungreat ungreat added the type-bug Something isn't working label Jul 24, 2024
@yizhouxw yizhouxw added this to the ODC 4.3.1 milestone Jul 24, 2024
Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare changed the title fix(login):set max_login_record_time_minutes default value to 0 in web mode fix(login): set max_login_record_time_minutes default value to 0 in web mode Jul 25, 2024
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 5f0902e into dev/4.3.x Jul 25, 2024
7 checks passed
@yhilmare yhilmare deleted the yiang_43x_max-login-record-time-minutes_default_0 branch July 25, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants