fix(recyclebin): fix failed to generate flashback sql #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhilmare
requested review from
MarkPotato777,
yizhouxw,
smallsheeeep and
PeachThinking
yhilmare
added a commit
that referenced
this pull request
Jan 15, 2024
* fix(recyclebin): fix failed to generate flashback sql * refactor(client): update submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
this pr fix a bug that odc can not generate flashback sql on some types, just like
normal index.Which issue(s) this PR fixes:
Fixes #295
Close #295
Special notes for your reviewer:
OceanBase only supports some specific types for flashback,
TABLE,VIEW,TENANT,DATABASEandSCHEMA.ODC will give up generating sql when recycle object's type is not in available types, that is why the api returns nothing.
To fix this bug, we generate a comment to tell the user that your recycle object's type is invalid rather than ignore it
Additional documentation e.g., usage docs, etc.: