fix(task-framework): starting task fails when environment variables exceed 2MB in Process Mode #3545
+119
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkPotato777
requested review from
yhilmare,
guowl3 and
yizhouxw
as code owners
LioRoger
reviewed
Sep 24, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/task/executor/TaskApplication.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/task/caller/JobCallerBuilder.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/task/caller/JobCallerBuilder.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/task/util/JobUtils.java
Show resolved
Hide resolved
...src/main/java/com/oceanbase/odc/service/task/executor/context/ProcessJobContextProvider.java
Show resolved
Hide resolved
yhilmare
reviewed
Sep 25, 2024
| * write JobContext to file in case of exceeding the environments size limit; set the file path in | ||
| * the environment instead | ||
| */ | ||
| String jobContextFilePath = JobUtils.getExecutorDataPath() + "/" + StringUtils.uuid() + ".enc"; |
| putEnv(JobEnvKeyConstants.ODC_JOB_CONTEXT, () -> JobUtils.toJson(context)); | ||
|
|
||
| if (runMode.isK8s()) { | ||
| putEnv(JobEnvKeyConstants.ODC_JOB_CONTEXT, () -> JobUtils.toJson(context)); |
There was a problem hiding this comment.
will k8s encounter the same problem that the process mode does?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
Starting task fails when environment variables exceed 2MB in Process Mode.
The solution is that write
JobContextinto file, and set the file path into the environment variable, instead of setting theJobContextinto the environment variable directly.The solution is
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: