Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql-execute): fix failed to print dbms output #361

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

yhilmare
Copy link
Contributor

What type of PR is this?

type-bug

What this PR does / why we need it:

dbms_output.put_line will not print anything on OceanBase 3.x when using ODC, this pr fix this bug.

odc pring dbms log by using this procedure dbms_output.get_lines which is added on OceanBase 4.x and not patched to OceanBase 3.x.

this pr use dbms_output.get_line to print dbms log, this method will work for both OceanBase 3.x and OceanBase 4.x~

Which issue(s) this PR fixes:

Fixes #348

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@yhilmare yhilmare added type-bug Something isn't working module-sql execution labels Sep 19, 2023
@yhilmare yhilmare added this to the ODC 4.2.1 milestone Sep 19, 2023
@yhilmare yhilmare self-assigned this Sep 19, 2023
@yhilmare yhilmare linked an issue Sep 19, 2023 that may be closed by this pull request
Copy link
Contributor

@smallsheeeep smallsheeeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhilmare yhilmare merged commit baa123b into dev/4.2.1 Sep 19, 2023
10 checks passed
@yhilmare yhilmare deleted the fix/shanlu_dbms_output branch September 19, 2023 05:41
yhilmare added a commit that referenced this pull request Jan 15, 2024
* fix(sql-execute): fix failed to print dbms output

* refactor(client): update submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-sql execution type-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: dbms output error, dbms_output.chararr type does not exist
2 participants