Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(osc): osc support ob ce add type ob mysql ce #390

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

krihy
Copy link
Collaborator

@krihy krihy commented Sep 22, 2023

What type of PR is this?

module-Online-shema-change
type-bug

What this PR does / why we need it:

add oms db type OB_MYSQL_CE

Which issue(s) this PR fixes:

create oms datasource by type OB_MYSQL_CE when target db version is ob ce

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@krihy krihy added type-bug Something isn't working priority-high module-Online schema change Online schema change labels Sep 22, 2023
@krihy krihy added this to the ODC 4.2.1 milestone Sep 22, 2023
@krihy krihy self-assigned this Sep 22, 2023
Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krihy krihy merged commit 4e308a1 into oceanbase:dev/4.2.1 Sep 25, 2023
5 checks passed
@krihy krihy deleted the yaobin_fix_osc_support_ob_ce branch September 25, 2023 02:47
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
* 1.foreign key unsupported
2.check table column is consistent

* 1.check table column is different

* format code

* 1.osc support OB_CE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-Online schema change Online schema change priority-high type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants