Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(unit-test): use blowfish encryption algorithm to replace aes #443

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

smallsheeeep
Copy link
Contributor

What type of PR is this?

type-refactor

What this PR does / why we need it:

Change the encryption algorithm from AES256_BASE64 to BlowFishZeroPadding_Base64 to avoid short string encrypted failed.

Special notes for your reviewer:

The unit test in odc and db-browser has been tested and passed.

@smallsheeeep smallsheeeep added the type-refactor refactor code or rename variables label Oct 9, 2023
@smallsheeeep smallsheeeep self-assigned this Oct 9, 2023
@smallsheeeep smallsheeeep changed the title refactor: use blowfish replace aes256 refactor(unit-test): use blowfish encryption algorithm to replace aes Oct 9, 2023
PeachThinking
PeachThinking previously approved these changes Oct 9, 2023
Copy link
Collaborator

@PeachThinking PeachThinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 13db652 into dev/4.2.x Oct 9, 2023
19 checks passed
@yhilmare yhilmare deleted the refactor/gaoda_change_aes_to_blowfish branch October 9, 2023 07:37
smallsheeeep added a commit that referenced this pull request Oct 11, 2023
…#443)

* refactor: use blowfish replace aes256

* fix ut

* fix
yhilmare pushed a commit that referenced this pull request Oct 11, 2023
#474)

* feat(unit-test): use cloud database as test cluster and adapt for github action (#411)

* add: unit test

* adapt: unit test

* add: workflow config

* fix: error ut

* fix: action config

* fix: ut and action config

* refine: workflow config

* fix: workflow config

* fix: workflow config

* fix: workflow config

* response to CR

* fix: low case env

* fix: low case env

* fix

* format

* refactor: ut

* check time zone

* check time zone

* fix: workflow config

* refactor: ut

* fix: error testcase

* fix

* fix

* fix

* refactor(unit-test): use blowfish encryption algorithm to replace aes (#443)

* refactor: use blowfish replace aes256

* fix ut

* fix
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
…#443)

* refactor: use blowfish replace aes256

* fix ut

* fix
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
#474)

* feat(unit-test): use cloud database as test cluster and adapt for github action (#411)

* add: unit test

* adapt: unit test

* add: workflow config

* fix: error ut

* fix: action config

* fix: ut and action config

* refine: workflow config

* fix: workflow config

* fix: workflow config

* fix: workflow config

* response to CR

* fix: low case env

* fix: low case env

* fix

* format

* refactor: ut

* check time zone

* check time zone

* fix: workflow config

* refactor: ut

* fix: error testcase

* fix

* fix

* fix

* refactor(unit-test): use blowfish encryption algorithm to replace aes (#443)

* refactor: use blowfish replace aes256

* fix ut

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-refactor refactor code or rename variables
Projects
Status: Developed
Development

Successfully merging this pull request may close these issues.

3 participants