Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(data-security): use disabeld recognition rules when select all rules #444

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix(data-security): use disabeld recognition rules when select all rules #444

merged 1 commit into from
Oct 9, 2023

Conversation

smallsheeeep
Copy link
Contributor

What type of PR is this?

type-bug
module-data security

Which issue(s) this PR fixes:

Here is a bug: when all recognition rules are selected, the disabled rules will be recognized together.
This PR will fix it by add enbaled into filtering condition
Fixes #433
Close #433

@smallsheeeep smallsheeeep added type-bug Something isn't working priority-medium module-Data security Parent module of data-masking, sensitive rule, masking algorithm, etc. labels Oct 9, 2023
@smallsheeeep smallsheeeep added this to the ODC 4.2.2 milestone Oct 9, 2023
@smallsheeeep smallsheeeep self-assigned this Oct 9, 2023
@smallsheeeep smallsheeeep linked an issue Oct 9, 2023 that may be closed by this pull request
[Bug]: When all recognition rules are selected, the disabled rules will be recognized together #433
Closed
yhilmare
yhilmare approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 74420e9 into dev/4.2.2 Oct 9, 2023
11 checks passed
@yhilmare yhilmare deleted the bugfix/gaoda_422_fix_scan_sensitive_column branch October 9, 2023 07:37
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
@smallsheeeep
fix: scan sensitive columns (#444)
c2d8288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhilmare yhilmare yhilmare approved these changes

@yizhouxw yizhouxw Awaiting requested review from yizhouxw

@PeachThinking PeachThinking Awaiting requested review from PeachThinking

Assignees

@smallsheeeep smallsheeeep

Labels
module-Data security Parent module of data-masking, sensitive rule, masking algorithm, etc. priority-medium type-bug Something isn't working
Projects
ODC
Archived in project
Milestone
ODC 4.2.2
Development

Successfully merging this pull request may close these issues.

[Bug]: When all recognition rules are selected, the disabled rules will be recognized together
2 participants
@smallsheeeep @yhilmare