Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database-change): database change failed if executing a sql more than 8 hour #455

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

smallsheeeep
Copy link
Contributor

What type of PR is this?

type-bug
module-database change task

What this PR does / why we need it:

ConnectionSession generated by DefaultConnectSessionFactory will be expired in 8 hour. So if a sql in database change task executing more than 8 hour, then the next sql will executing failed.
This PR fix it by setting the timeout to the timeout of the task rather than 8 hour.

Which issue(s) this PR fixes:

Fixes #453

@smallsheeeep smallsheeeep added this to the ODC 4.2.2 milestone Oct 10, 2023
@smallsheeeep smallsheeeep self-assigned this Oct 10, 2023
@smallsheeeep smallsheeeep changed the title fix: database change failed fix(database-change): database change failed if executing a sql more than 8 hour Oct 10, 2023
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit d5e87c7 into dev/4.2.2 Oct 10, 2023
11 checks passed
@yhilmare yhilmare deleted the bugfix/gaoda_422_fix_database_change_failed branch October 10, 2023 05:32
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: failed to run a database change task which contains sql that requires more than 8 hours of run time
2 participants