Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-security): exist sensitive is not filtered and view desensitization data failed #509

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

smallsheeeep
Copy link
Contributor

What type of PR is this?

type-bug
module-data security

What this PR does / why we need it:

There are two bug:

  1. If the table name or database name is uppercase in MySQL mode, the data masking will failed. The root cause is that ODC will change DB object name to lowcase in MySQL mode. If the table name is uppercase in DB Server, then ODC cannot find the right table.
  2. The exists sensitive is not filtered.
    This PR fix above two bugs. Table name and column name stored in ODC metaDB is case-insensitive. So ODC cannot deal with sensitive columns with same name in different case. So, ODC will defaultly change the object name to lowcase in MySQL mode and uppercase in Oracle mode. If the object name is quoted, then ODC will keep the case themselves.

Which issue(s) this PR fixes:

Fixes #475

Special notes for your reviewer:

Self-test passed

@smallsheeeep smallsheeeep added type-bug Something isn't working priority-medium module-Data security Parent module of data-masking, sensitive rule, masking algorithm, etc. labels Oct 16, 2023
@smallsheeeep smallsheeeep added this to the ODC 4.2.2 milestone Oct 16, 2023
@smallsheeeep smallsheeeep self-assigned this Oct 16, 2023
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit bc1aa60 into dev/4.2.2 Oct 16, 2023
19 checks passed
@yhilmare yhilmare deleted the bugfix/gaoda_422_fix_view_masking branch October 16, 2023 09:55
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
…ization data failed (#509)

* fix: case sensitive

* add: DBColumn case-insensitive

* fix: case-insensitive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-Data security Parent module of data-masking, sensitive rule, masking algorithm, etc. priority-medium type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants