Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(databasechange): fix task costs too much time to start up #551

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

yhilmare
Copy link
Contributor

What type of PR is this?

type-bug

What this PR does / why we need it:

databasechange task takes too long time to start up which causes error printing by monitor task. I move the sql script read logic to task running phase to reduce the startup time.

Which issue(s) this PR fixes:

Fixes #550

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@yhilmare yhilmare added the type-bug Something isn't working label Oct 19, 2023
@yhilmare yhilmare added this to the ODC 4.2.2 milestone Oct 19, 2023
@yhilmare yhilmare self-assigned this Oct 19, 2023
Copy link
Collaborator

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhilmare yhilmare merged commit 8dffddf into dev/4.2.2 Oct 19, 2023
19 checks passed
@yhilmare yhilmare deleted the fix/shanlu_spped_up_task branch October 19, 2023 05:59
yhilmare added a commit that referenced this pull request Jan 15, 2024
* fix(databasechange): fix task costs too much time to start up

* refactor: move session init first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-medium type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants