fix(result-export): failed to convert CSV file into Excel file #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhilmare
pushed a commit
that referenced
this pull request
Jan 15, 2024
* use backslash as escape char for Excel format * set replaceObjectIfExists to true for MIX mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
When export result set into Excel format, and the records contains
\tlikexxx\txxx, OB-DUMPER will use double quote as escape char because of ODC's setting. So the final form in the file is like...,"xxx" xxxx",....But when convert it into .xls format, ODC use
org.apache.commons.csvto parse CSV file. It can not parse this record, and would report IOException.So when export into csv, we use backslash instead of quote. The above record will be translated like
..."xxx\ xxx"..., which common-csv could recognize.Which issue(s) this PR fixes:
Fixes #457
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: