fix(db-browser): cannot get table charset in native mysql mode #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeachThinking
added
type-bug
yhilmare
reviewed
Oct 24, 2023
...in/java/com/oceanbase/tools/dbbrowser/schema/mysql/MySQLNoGreaterThan5740SchemaAccessor.java
Show resolved
Hide resolved
yhilmare
reviewed
Oct 24, 2023
...in/java/com/oceanbase/tools/dbbrowser/schema/mysql/MySQLNoGreaterThan5740SchemaAccessor.java
Show resolved
Hide resolved
...in/java/com/oceanbase/tools/dbbrowser/schema/mysql/MySQLNoGreaterThan5740SchemaAccessor.java
Outdated
Show resolved
Hide resolved
...in/java/com/oceanbase/tools/dbbrowser/schema/mysql/MySQLNoGreaterThan5740SchemaAccessor.java
Show resolved
Hide resolved
yhilmare
deleted the
jingtian_422_fix_cannot_get_table_charset_in_mysql
branch
yhilmare
pushed a commit
that referenced
this pull request
Jan 15, 2024
* fix cannot get table charset in mysql mode * fix listTableIndexes ut test * get table options by parser * response to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
module-Database object
What this PR does / why we need it:
Fix cannot get table charset in native mysql mode. OB mysql get table charset by
DBSchemaAccessorUtil#obtainOptionsByParsewhich is not work for native mysql mode.we can get table by parse table ddl in both mysql and ob mysql mode. add
obtainOptionsByParsermethod and use it to get table options.optimize DBSchemaAccessor ut test by create
private static DBSchemaAccessor accessorfix
@Ignore("TODO: fix this test case")ut test. I consulted kernel classmates and found that thecommentfield of theinformation_schema.STATISTICStable and thecommentfield of theshow index fromquery have different sources and meanings. Thecommentfield ofinformation_schema.STATISTICScannot be used to indicate the status of the index, so forMap<String, List<DBTableIndex >> listTableIndexes(String schemaName);method does not query whether the index is available. Actually only theList<DBTableIndex> listTableIndexes(String schemaName, String tableName)method needs to provide the available status of the index.Which issue(s) this PR fixes:
Fixes #582
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: