-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix failed to query data and sql rules changing is not recorded by audit event #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhilmare
added
type-bug
Something isn't working
enhancement
New feature or request
labels
Oct 24, 2023
This was
linked to
issues
Oct 24, 2023
yizhouxw
reviewed
Oct 25, 2023
...service/src/main/java/com/oceanbase/odc/service/session/interceptor/SqlCheckInterceptor.java
Outdated
Show resolved
Hide resolved
server/odc-core/src/main/java/com/oceanbase/odc/core/shared/constant/AuditEventAction.java
Outdated
Show resolved
Hide resolved
…/shanlu_fix_issues_found_by_playsite
yizhouxw
reviewed
Oct 25, 2023
server/odc-core/src/main/java/com/oceanbase/odc/core/shared/constant/ErrorCodes.java
Outdated
Show resolved
Hide resolved
server/odc-core/src/main/java/com/oceanbase/odc/core/shared/constant/AuditEventType.java
Outdated
Show resolved
Hide resolved
server/odc-core/src/main/resources/i18n/BusinessMessages.properties
Outdated
Show resolved
Hide resolved
yizhouxw
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
yhilmare
added a commit
that referenced
this pull request
Jan 15, 2024
…by audit event (#608) * fix: fix several issues found in play site * feat: add audit event for security management * fix: fix unit test cases * reponse to cr comments * response to cr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
type-enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #606 #605 #604
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: