Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix failed to query data and sql rules changing is not recorded by audit event #608

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

yhilmare
Copy link
Contributor

What type of PR is this?

type-bug
type-enhancement

What this PR does / why we need it:

  1. remove sql check interceptor when query table data.
  2. SQL security specification modifications are included in operational audits.
  3. define a special error code and throw an exception when failed to query database's version

Which issue(s) this PR fixes:

Fixes #606 #605 #604

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit c8c95a4 into dev/4.2.2 Oct 25, 2023
19 checks passed
@yhilmare yhilmare deleted the fix/shanlu_fix_issues_found_by_playsite branch October 25, 2023 02:39
yhilmare added a commit that referenced this pull request Jan 15, 2024
…by audit event (#608)

* fix: fix several issues found in play site

* feat: add audit event for security management

* fix: fix unit test cases

* reponse to cr comments

* response to cr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request type-bug Something isn't working
Projects
Archived in project
3 participants