feat(dlm):support configuring limiter #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guowl3
requested review from
yhilmare,
MarkPotato777,
yizhouxw and
smallsheeeep
yizhouxw
reviewed
Oct 26, 2023
There was a problem hiding this comment.
the class DlmLimiterConfig may not clear for API model.
e.g. what is the postfix limit means, batch limit or rate limit.
do we have plan to offer more configurable limit ability?
crrenttly all limit abilit belong to rate limit, it will be okay to use RateLimitConfiguration.
or, may DlmLimitConfiguration, with fields:
- max-rows-per-second
- max-size-per-second
- batch-rows
server/odc-core/src/main/resources/i18n/BusinessMessages.properties
Outdated
Show resolved
Hide resolved
.../odc-server/src/main/java/com/oceanbase/odc/server/web/controller/v2/ScheduleController.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/dlm/model/DataDeleteParameters.java
Outdated
Show resolved
Hide resolved
yizhouxw
changed the title
yhilmare
pushed a commit
that referenced
this pull request
Jan 15, 2024
* DLM supports configuring limiter config. * DLM supports configuring limiter config. * fix wrong field. * support configuring max value of limiter. * support configuring max value of limiter. * show limiter config in detail. * add util. * fix ut * response comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-feature
What this PR does / why we need it:
The current task current limit configuration can only be modified in the metadb, which is not user-friendly. Now users are allowed to configure it on a white screen.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: