fix(database): use datasource's environment as database's environment to prevent data inconsistency #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkPotato777
commented
Oct 31, 2023
...odc-service/src/main/java/com/oceanbase/odc/service/connection/database/DatabaseService.java
Show resolved
Hide resolved
yhilmare
pushed a commit
that referenced
this pull request
Jan 15, 2024
… to prevent data inconsistency (#659) * ignore connect_database.id * fix conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
Both
connect_connectionandconnect_databasemaintain theenvironemnt_idwhich may cause data inconsistencies.For example, the migration of the
environment_idin theconnect_connectiontable occurs during theTeamOrganizationMigratorprocess, which is triggered when the first user of the current organization logs in. On the other hand, the synchronization ofconnect_databaseis triggered by a scheduled task. IfsyncDatabasehappens beforeTeamOrganizationMigrator, then the value ofconnect_database.environment_idwill be -1.The solution is that we no longer rely on the
environment_idof theconnect_database, but set the environment of the database to the environment of the data source in the conversion layer of entity to model. Considering compatibility, we do not change any schema or migrate any data here, and the caller of the DatabaseService doesn't need to care about this change, because all changes happen in-ground.Which issue(s) this PR fixes:
Fixes #575
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: