Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(result-set-export): get wrong filename for result-set export task on cloud #685

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

LuckyPickleZZ
Copy link
Collaborator

What type of PR is this?

type-bug

What this PR does / why we need it:

There is a code bug which will lead to get wrong filename for result-set export task. So we use user-configured filename to upload result instead of origin filename.

Which issue(s) this PR fixes:

none

@LuckyPickleZZ LuckyPickleZZ added this to the ODC 4.2.2 milestone Nov 1, 2023
@LuckyPickleZZ LuckyPickleZZ self-assigned this Nov 1, 2023
@LuckyPickleZZ LuckyPickleZZ marked this pull request as ready for review November 1, 2023 03:55
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare changed the title fix(result-set-export): get wrong filename for result-set export task on alibaba cloud fix(result-set-export): get wrong filename for result-set export task on cloud Nov 1, 2023
@yhilmare yhilmare merged commit 91ec9e0 into dev/4.2.2 Nov 1, 2023
19 checks passed
@yhilmare yhilmare deleted the wenmu_422_fix_error_result_export_filename branch November 1, 2023 08:56
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
… on cloud (#685)

* fix wrong filename for result set export task

* fix wrong filename for result set export task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants