Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SSO):saved SSO intergration test login failed #698

Merged

Conversation

ungreat
Copy link
Collaborator

@ungreat ungreat commented Nov 1, 2023

What type of PR is this?

saved SSO intergration test login failed

What this PR does / why we need it:

cause by issue
Encryption#secret is set to Access.WRITE_ONLY

Which issue(s) this PR fixes:

Fixes #674
fix can't test a saved SSO intergration login

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@ungreat ungreat added type-bug Something isn't working module-External integration External system integration such as SSO, Approval, SQL interceptor etc. labels Nov 1, 2023
@yhilmare yhilmare added this to the ODC 4.2.2 milestone Nov 1, 2023
Copy link
Contributor

@smallsheeeep smallsheeeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhilmare yhilmare merged commit ba0c17b into dev/4.2.2 Nov 2, 2023
19 checks passed
@yhilmare yhilmare deleted the yiang_420x_fix_saved_sso_integration_test_login_failed branch November 2, 2023 03:19
yhilmare pushed a commit that referenced this pull request Nov 8, 2023
yhilmare pushed a commit that referenced this pull request Nov 8, 2023
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-External integration External system integration such as SSO, Approval, SQL interceptor etc. type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants