fix(sql-parser): failed to report syntax error if the input's any prefix is grammatical #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhilmare
added
type-bug
yhilmare
added a commit
that referenced
this pull request
Jan 15, 2024
…fix is grammatical (#699) * builds: upgrade db-browser's version * upgrade the parser's version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
the parser will not report any syntax error if the input's any prefix is grammatical.
eg.
the sql above has syntax error obviously but the parser will consider that this is a sql without any syntax error cause that the prefix of this sql
select * from testis grammatical.the root cause of this issue is that the parser does not parse a sql from the beginning to the end. The parser will return when it get a grammatical statement.
you can get more infos from the issue #693
Which issue(s) this PR fixes:
Fixes #693
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: