-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notification): support send notification when schedule job failed #711
feat(notification): support send notification when schedule job failed #711
Conversation
server/odc-service/src/main/java/com/oceanbase/odc/service/quartz/OdcJobListener.java
Outdated
Show resolved
Hide resolved
…tion # Conflicts: # server/odc-service/src/main/java/com/oceanbase/odc/service/quartz/OdcJobListener.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions that we can discuss:
- Would it be better if we do not enqueue events while there is no notification policy configured in the current organization? I doubt if all events are pushed into the event queue, the conversion from event to notification will be delayed and so does the notification sending.
- Do we need a pressure test to make sure of the stability?
- Do we need to refine the configuration values of NotificationProperties? or add some other configurations?
As a temporary solution, I believe that all of the above issues can be solved by reducing the scheduling period of periodic tasks. |
okay, you could conduct a quick test to confirm the scheduling and batch-size configurations~ |
.../odc-service/src/main/java/com/oceanbase/odc/service/notification/NotificationSchedules.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/notification/EventFilter.java
Outdated
Show resolved
Hide resolved
.../odc-service/src/main/java/com/oceanbase/odc/service/notification/JdbcNotificationQueue.java
Outdated
Show resolved
Hide resolved
...odc-service/src/main/java/com/oceanbase/odc/service/notification/NotificationDispatcher.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/notification/Broker.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/notification/Broker.java
Outdated
Show resolved
Hide resolved
…tion # Conflicts: # server/integration-test/src/test/java/com/oceanbase/odc/service/flow/ExpiredDocumentProviderTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#711) * fix NPE when no recipients configured * add NotificationPolicyFilter to match expression * enqueue event when job failed * fix message would be resent on exception * remove unused imports * restore debug * add region into message * add UT * format code * fix UT failure * resolve conflicts * fix UT * format code * a failed notification shouldn't block others * optimize performance * format code * response to CR * use NotificationScheduleConfiguration to replace NotificationSchedules * fix JPA error * fix UT * format code * format code * ignore UT * fix * rename script * remove async * add `taskId` into labels * add `region` into labels * remove unused code
What type of PR is this?
type-feature
What this PR does / why we need it:
Which issue(s) this PR fixes: