Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-transfer): support saving export objects #73

Conversation

LuckyPickleZZ
Copy link
Collaborator

What type of PR is this?

type-bug
module-datatransfer

What this PR does / why we need it:

For now export objects could only be shown after task completion. Therefore, the approver cannot see which objects will be exported during approval. Resulting in inability to approve.

In this PR, the above problem is fixed. Approver can see all export objects immediately afer task created.
Plus, this PR also supports export 'type' objects.

Which issue(s) this PR fixes:

#63

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LuckyPickleZZ LuckyPickleZZ changed the base branch from dev/4.2.x to dev/4.2.1 August 31, 2023 02:43
@LuckyPickleZZ LuckyPickleZZ merged commit e884513 into oceanbase:dev/4.2.1 Aug 31, 2023
4 checks passed
krihy pushed a commit to krihy/odcfork that referenced this pull request Aug 31, 2023
* support type for export

* save export objects when create flow task

* fix get empty result
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
* support type for export

* save export objects when create flow task

* fix get empty result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: data-transfer task should display export objects before completion
2 participants