Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql-execute): fix the issue where the number type is displayed using scientific notation when the value is 0.0000000 #764

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

yhilmare
Copy link
Contributor

What type of PR is this?

type-bug

What this PR does / why we need it:

the number content will be displayed by using scientific notation when the value is 0.0000000 which confused the user. this pr fix this problem.

I have tested for three number datatype: number, decimal and fixed and I have also tested these datatypes with zerofill settings. Both two scenarios are normal.

Which issue(s) this PR fixes:

Fixes #762

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@yhilmare yhilmare added type-bug Something isn't working module-sql execution labels Nov 10, 2023
@yhilmare yhilmare added this to the ODC 4.2.2-bp milestone Nov 10, 2023
@yhilmare yhilmare self-assigned this Nov 10, 2023
Copy link
Contributor

@smallsheeeep smallsheeeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhilmare yhilmare merged commit f865778 into dev/4.2.2 Nov 13, 2023
11 checks passed
@yhilmare yhilmare deleted the fix/shanlu_mysql_decimal_display branch November 13, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-sql execution type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants